-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: fix nri reconnect params #2067
koordlet: fix nri reconnect params #2067
Conversation
Signed-off-by: saintube <saintube@foxmail.com>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2067 +/- ##
==========================================
- Coverage 68.63% 68.63% -0.01%
==========================================
Files 430 430
Lines 39518 39534 +16
==========================================
+ Hits 27125 27133 +8
- Misses 10049 10059 +10
+ Partials 2344 2342 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -248,13 +261,17 @@ func (p *NriServer) RemovePodSandbox(pod *api.PodSandbox) error { | |||
func (p *NriServer) onClose() { | |||
//TODO: consider the pod status during restart | |||
retryFunc := func() (bool, error) { | |||
stub, err := stub.New(p, append(opts, stub.WithOnClose(p.onClose))...) | |||
if p.stopped.Load() { // if set to stopped, no longer reconnect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, currently, nri server never stop, right ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Currently, this method is used by the testing.
Ⅰ. Describe what this PR does
TestNriServer_Start
in the koordlet NRI module.Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test